fix: on windows, add path use absolute, more add object for father path #3010
Conversation
|
I believe it would be more appropriate to change line 401 For reference on standard slash paths #1933 (comment) ping @Kubuxu |
|
I think filepath.EvalSymlinks function cause problem，in winodws，before call EvalSymlinks，fpath is use “\”，but after called fpath changed for “/"，so re-introduced this problem. |
License: MIT Signed-off-by: liliuhai <[email protected]>
|
Sorry, I neglected the multiple return values of EvalSymlinks, this is what I should have suggested: djdv@31b4cbb |
|
thanks, like this the problem can fixed |
|
Sounds good, we'll have to wait for an IPFS member to make judgment since I don't know which method is preferable or if anything else has to be done. I'm glad this regression was spotted, thank you for finding it! |
| @@ -416,7 +417,7 @@ func appendFile(fpath string, argDef *cmds.Argument, recursive, hidden bool) (fi | |||
| } | |||
| } | |||
|
|
|||
| return files.NewSerialFile(path.Base(fpath), fpath, hidden, stat) | |||
| return files.NewSerialFile(path.Base(filepath.ToSlash(fpath)), fpath, hidden, stat) | |||
There was a problem hiding this comment.
instead of doing this here, we should on line 401 do:
fpath = filepath.Clean(fpath)
fpath, err = filepath.EvalSymlinks(fpath)
...
fpath = filepath.ToSlash(fpath)
|
I've taken over this PR in #3023. Thanks for bringing it up to us. We need to work on Windows CI. |
old code run on winodw,use add -r commands,if use absolute path as param,the result have more added object like father path,but use relativity path,no this problem.
License: MIT
Signed-off-by: liliuhai [email protected]